From df9503ee97ff82bbe4e6d03ff63bc653ebd63f1a Mon Sep 17 00:00:00 2001 From: averikitsch Date: Tue, 14 Jan 2020 11:10:55 -0800 Subject: [PATCH] Fix file in readme --- example-workflows/gke/.github/workflows/gke.yml | 2 +- example-workflows/gke/README.md | 4 +++- example-workflows/gke/deployment.yml | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/example-workflows/gke/.github/workflows/gke.yml b/example-workflows/gke/.github/workflows/gke.yml index 50c72bbc..c44cad29 100644 --- a/example-workflows/gke/.github/workflows/gke.yml +++ b/example-workflows/gke/.github/workflows/gke.yml @@ -82,7 +82,7 @@ jobs: run: | gcloud container clusters get-credentials $GKE_CLUSTER \ --zone $GKE_ZONE --project $GKE_PROJECT - ./kustomize edit set image gcr.io/$GKE_PROJECT/$IMAGE:${GITHUB_SHA} + ./kustomize edit set image gcr.io/$GKE_PROJECT/$IMAGE:$GITHUB_SHA ./kustomize build . | kubectl apply -f - kubectl rollout status deployment/gke-test kubectl get services -o wide diff --git a/example-workflows/gke/README.md b/example-workflows/gke/README.md index 3dd2e97a..73bc6b8a 100644 --- a/example-workflows/gke/README.md +++ b/example-workflows/gke/README.md @@ -40,12 +40,14 @@ For pushes to the _default_ branch, `master`, the workflow will: 1. [Create a GKE cluster][cluster] or select an existing GKE cluster. -1. Update `deployment.yml` with the following values: +1. Update `gke.yml` with the following values: * `GKE_CLUSTER`: the name of your cluster. * `GKE_ZONE`: the zone your cluster resides. + * `IMAGE`: your preferred Docker image name. + You can find the names of your clusters using the command: `gcloud container clusters list`, and the zone using the command: `gcloud container clusters describe `. diff --git a/example-workflows/gke/deployment.yml b/example-workflows/gke/deployment.yml index fc44d094..6420930c 100644 --- a/example-workflows/gke/deployment.yml +++ b/example-workflows/gke/deployment.yml @@ -22,7 +22,7 @@ spec: rollingUpdate: maxSurge: 1 maxUnavailable: 1 - minReadySeconds: 5 + minReadySeconds: 5 template: metadata: labels: @@ -30,7 +30,7 @@ spec: spec: containers: - name: gke-test - image: gcr.io/github-test-238118/gke-test:TAG + image: gcr.io/GKE_PROJECT/IMAGE:TAG ports: - containerPort: 5000 resources: