google-github-actions/setup-gcloud
1
0
Fork 0
mirror of https://github.com/google-github-actions/setup-gcloud.git synced 2026-08-20 10:19:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Only warn when there are no authentications (#671)

Browse source 
This fixes an issue where a warning message would be printed on systems
using ADC from the metadata server.

Fixes https://github.com/google-github-actions/setup-gcloud/issues/670
This commit is contained in:
Seth Vargo 2023-12-20 22:31:37 -05:00 • committed by GitHub
parent f14c440264
commit fd83cd9564
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
dist/index.js vendored
View file

File diff suppressed because one or more lines are too long

6
src/main.ts
View file

@ -21,6 +21,7 @@ import {
bestVersion,
installComponent,
installGcloudSDK,
isAuthenticated,
setProject,
} from '@google-github-actions/setup-cloud-sdk';
import {
@ -102,9 +103,10 @@ export async function run(): Promise<void> {
if (credFile) {
await authenticateGcloudSDK(credFile);
core.info('Successfully authenticated');
} else {
} else if (!(await isAuthenticated())) {
core.warning(
'No authentication found for gcloud, authenticate with `google-github-actions/auth`.',
`The gcloud CLI is not authenticated. Authenticate by adding the ` +
`"google-github-actions/auth" step prior this one.`,
);
}

1
tests/setup-gcloud.test.ts
View file

@ -64,6 +64,7 @@ const defaultMocks = (
}),
authenticateGcloudSDK: m.method(setupGcloud, 'authenticateGcloudSDK', () => {}),
isAuthenticated: m.method(setupGcloud, 'isAuthenticated', () => {}),
isInstalled: m.method(setupGcloud, 'isInstalled', () => {
return true;
}),